remove file when tar failed

fengxx · fengxx · commit 989633a22d9c · 2017-05-23T23:36:38.000+08:00
diff --git a/src/main/java/com/github/dockerjava/core/command/CopyArchiveToContainerCmdImpl.java b/src/main/java/com/github/dockerjava/core/command/CopyArchiveToContainerCmdImpl.java
@@ -125,11 +125,14 @@ public Void exec() throws NotFoundException {
                         "Only one of host resource or tar input stream should be defined to perform the copy, not both");
             }
             // We compress the given path, call exec so that the stream is consumed and then close it our self
-            Path toUpload;
+            Path toUpload = null;
             try {
                 toUpload = Files.createTempFile("docker-java", ".tar.gz");
                 CompressArchiveUtil.tar(Paths.get(hostResource), toUpload, true, dirChildrenOnly);
             } catch (IOException createFileIOException) {
+                if (toUpload != null) {
+                    toUpload.toFile().delete();
+                }
                 throw new DockerClientException("Unable to perform tar on host resource " + this.hostResource, createFileIOException);
             }
             try (InputStream uploadStream = Files.newInputStream(toUpload)) {
