auto close in ResultCallback#awaitCompletion (#1415)

bsideup · web-flow · commit 75b328f41684 · 2020-06-16T14:58:45.000+02:00
diff --git a/docker-java-api/src/main/java/com/github/dockerjava/api/async/ResultCallbackTemplate.java b/docker-java-api/src/main/java/com/github/dockerjava/api/async/ResultCallbackTemplate.java
@@ -87,10 +87,18 @@ public void close() throws IOException {
      */
     @SuppressWarnings("unchecked")
     public RC_T awaitCompletion() throws InterruptedException {
-        completed.await();
-        // eventually (re)throws RuntimeException
-        throwFirstError();
-        return (RC_T) this;
+        try {
+            completed.await();
+            // eventually (re)throws RuntimeException
+            throwFirstError();
+            return (RC_T) this;
+        } finally {
+            try {
+                close();
+            } catch (IOException e) {
+                LOGGER.debug("Failed to close", e);
+            }
+        }
     }
 
     /**
@@ -99,9 +107,17 @@ public RC_T awaitCompletion() throws InterruptedException {
      *         before {@link ResultCallback#onComplete()} was called.
      */
     public boolean awaitCompletion(long timeout, TimeUnit timeUnit) throws InterruptedException {
-        boolean result = completed.await(timeout, timeUnit);
-        throwFirstError();
-        return result;
+        try {
+            boolean result = completed.await(timeout, timeUnit);
+            throwFirstError();
+            return result;
+        } finally {
+            try {
+                close();
+            } catch (IOException e) {
+                LOGGER.debug("Failed to close", e);
+            }
+        }
     }
 
     /**
