Merge branch 'master' into add_npipe

aroskuski · web-flow · commit 6fa2a82c41a0 · 2022-01-19T21:23:04.000-05:00
diff --git a/docker-java-api/src/main/java/com/github/dockerjava/api/DockerClient.java b/docker-java-api/src/main/java/com/github/dockerjava/api/DockerClient.java
@@ -56,6 +56,7 @@
 import com.github.dockerjava.api.command.RemoveNetworkCmd;
 import com.github.dockerjava.api.command.RemoveSecretCmd;
 import com.github.dockerjava.api.command.RemoveServiceCmd;
+import com.github.dockerjava.api.command.RemoveSwarmNodeCmd;
 import com.github.dockerjava.api.command.RemoveVolumeCmd;
 import com.github.dockerjava.api.command.RenameContainerCmd;
 import com.github.dockerjava.api.command.ResizeContainerCmd;
@@ -342,6 +343,15 @@ public interface DockerClient extends Closeable {
      */
     UpdateSwarmNodeCmd updateSwarmNodeCmd();
 
+    /**
+     * Remove the swarm node
+     *
+     * @param swarmNodeId swarmNodeId
+     * @return the command
+     * @since 1.24
+     */
+    RemoveSwarmNodeCmd removeSwarmNodeCmd(String swarmNodeId);
+
     /**
      * List nodes in swarm
      *
diff --git a/docker-java-api/src/main/java/com/github/dockerjava/api/DockerClientDelegate.java b/docker-java-api/src/main/java/com/github/dockerjava/api/DockerClientDelegate.java
@@ -56,6 +56,7 @@
 import com.github.dockerjava.api.command.RemoveNetworkCmd;
 import com.github.dockerjava.api.command.RemoveSecretCmd;
 import com.github.dockerjava.api.command.RemoveServiceCmd;
+import com.github.dockerjava.api.command.RemoveSwarmNodeCmd;
 import com.github.dockerjava.api.command.RemoveVolumeCmd;
 import com.github.dockerjava.api.command.RenameContainerCmd;
 import com.github.dockerjava.api.command.ResizeContainerCmd;
@@ -423,6 +424,11 @@ public UpdateSwarmNodeCmd updateSwarmNodeCmd() {
         return getDockerClient().updateSwarmNodeCmd();
     }
 
+    @Override
+    public RemoveSwarmNodeCmd removeSwarmNodeCmd(String swarmNodeId) {
+        return getDockerClient().removeSwarmNodeCmd(swarmNodeId);
+    }
+
     @Override
     public ListSwarmNodesCmd listSwarmNodesCmd() {
         return getDockerClient().listSwarmNodesCmd();
diff --git a/docker-java-api/src/main/java/com/github/dockerjava/api/command/LogContainerCmd.java b/docker-java-api/src/main/java/com/github/dockerjava/api/command/LogContainerCmd.java
@@ -25,6 +25,8 @@
  * @param since
  *            - UNIX timestamp (integer) to filter logs. Specifying a timestamp will only output log-entries since that timestamp. Default:
  *            0 (unfiltered)
+ * @param until
+ *            - Only return logs before this time, as a UNIX timestamp. Default: 0
  */
 public interface LogContainerCmd extends AsyncDockerCmd<LogContainerCmd, Frame> {
 
@@ -49,6 +51,9 @@ public interface LogContainerCmd extends AsyncDockerCmd<LogContainerCmd, Frame>
     @CheckForNull
     Integer getSince();
 
+    @CheckForNull
+    Integer getUntil();
+
     LogContainerCmd withContainerId(@Nonnull String containerId);
 
     /**
@@ -69,6 +74,8 @@ public interface LogContainerCmd extends AsyncDockerCmd<LogContainerCmd, Frame>
 
     LogContainerCmd withSince(Integer since);
 
+    LogContainerCmd withUntil(Integer until);
+
     /**
      * @throws com.github.dockerjava.api.NotFoundException
      *             No such container
diff --git a/docker-java-api/src/main/java/com/github/dockerjava/api/command/RemoveSwarmNodeCmd.java b/docker-java-api/src/main/java/com/github/dockerjava/api/command/RemoveSwarmNodeCmd.java
@@ -18,7 +18,7 @@ public interface RemoveSwarmNodeCmd extends SyncDockerCmd<Void> {
     @CheckForNull
     Boolean hasForceEnabled();
 
-    RemoveSwarmNodeCmd withContainerId(@Nonnull String containerId);
+    RemoveSwarmNodeCmd withSwarmNodeId(@Nonnull String swarmNodeId);
 
     RemoveSwarmNodeCmd withForce(Boolean force);
 
diff --git a/docker-java-api/src/main/java/com/github/dockerjava/api/model/ContainerMount.java b/docker-java-api/src/main/java/com/github/dockerjava/api/model/ContainerMount.java
@@ -106,7 +106,7 @@ public ContainerMount withDriver(String driver) {
      */
     @CheckForNull
     public String getMode() {
-        return driver;
+        return mode;
     }
 
     /**
diff --git a/docker-java-core/src/main/java/com/github/dockerjava/core/DockerClientImpl.java b/docker-java-core/src/main/java/com/github/dockerjava/core/DockerClientImpl.java
@@ -58,6 +58,7 @@
 import com.github.dockerjava.api.command.RemoveNetworkCmd;
 import com.github.dockerjava.api.command.RemoveSecretCmd;
 import com.github.dockerjava.api.command.RemoveServiceCmd;
+import com.github.dockerjava.api.command.RemoveSwarmNodeCmd;
 import com.github.dockerjava.api.command.RemoveVolumeCmd;
 import com.github.dockerjava.api.command.RenameContainerCmd;
 import com.github.dockerjava.api.command.ResizeContainerCmd;
@@ -140,6 +141,7 @@
 import com.github.dockerjava.core.command.RemoveNetworkCmdImpl;
 import com.github.dockerjava.core.command.RemoveSecretCmdImpl;
 import com.github.dockerjava.core.command.RemoveServiceCmdImpl;
+import com.github.dockerjava.core.command.RemoveSwarmNodeCmdImpl;
 import com.github.dockerjava.core.command.RemoveVolumeCmdImpl;
 import com.github.dockerjava.core.command.RenameContainerCmdImpl;
 import com.github.dockerjava.core.command.ResizeContainerCmdImpl;
@@ -616,6 +618,11 @@ public UpdateSwarmNodeCmd updateSwarmNodeCmd() {
         return new UpdateSwarmNodeCmdImpl(getDockerCmdExecFactory().updateSwarmNodeCmdExec());
     }
 
+    @Override
+    public RemoveSwarmNodeCmd removeSwarmNodeCmd(String swarmNodeId) {
+        return new RemoveSwarmNodeCmdImpl(getDockerCmdExecFactory().removeSwarmNodeCmdExec(), swarmNodeId);
+    }
+
     @Override
     public ListSwarmNodesCmd listSwarmNodesCmd() {
         return new ListSwarmNodesCmdImpl(getDockerCmdExecFactory().listSwarmNodeCmdExec());
diff --git a/docker-java-core/src/main/java/com/github/dockerjava/core/command/LogContainerCmdImpl.java b/docker-java-core/src/main/java/com/github/dockerjava/core/command/LogContainerCmdImpl.java
@@ -24,14 +24,16 @@
  * @param since
  *            - UNIX timestamp (integer) to filter logs. Specifying a timestamp will only output log-entries since that timestamp. Default:
  *            0 (unfiltered)
+ * @param until
+ *            - Only return logs before this time, as a UNIX timestamp. Default: 0
  */
 public class LogContainerCmdImpl extends AbstrAsyncDockerCmd<LogContainerCmd, Frame> implements LogContainerCmd {
 
     private String containerId;
 
     private Boolean followStream, timestamps, stdout, stderr;
 
-    private Integer tail, since;
+    private Integer tail, since, until;
 
     public LogContainerCmdImpl(LogContainerCmd.Exec exec, String containerId) {
         super(exec);
@@ -73,6 +75,11 @@ public Integer getSince() {
         return since;
     }
 
+    @Override
+    public Integer getUntil() {
+        return until;
+    }
+
     @Override
     public LogContainerCmd withContainerId(String containerId) {
         checkNotNull(containerId, "containerId was not specified");
@@ -122,6 +129,12 @@ public LogContainerCmd withSince(Integer since) {
         return this;
     }
 
+    @Override
+    public LogContainerCmd withUntil(Integer until) {
+        this.until = until;
+        return this;
+    }
+
     @Override
     public String toString() {
         return ReflectionToStringBuilder.toString(this, ToStringStyle.SHORT_PREFIX_STYLE);
diff --git a/docker-java-core/src/main/java/com/github/dockerjava/core/command/RemoveSwarmNodeCmdImpl.java b/docker-java-core/src/main/java/com/github/dockerjava/core/command/RemoveSwarmNodeCmdImpl.java
@@ -17,9 +17,9 @@ public class RemoveSwarmNodeCmdImpl extends AbstrDockerCmd<RemoveSwarmNodeCmd, V
 
     private Boolean force;
 
-    public RemoveSwarmNodeCmdImpl(RemoveSwarmNodeCmd.Exec exec, String containerId) {
+    public RemoveSwarmNodeCmdImpl(RemoveSwarmNodeCmd.Exec exec, String swarmNodeId) {
         super(exec);
-        withContainerId(containerId);
+        withSwarmNodeId(swarmNodeId);
     }
 
     @Override
@@ -35,7 +35,7 @@ public Boolean hasForceEnabled() {
     }
 
     @Override
-    public RemoveSwarmNodeCmd withContainerId(@Nonnull String swarmNodeId) {
+    public RemoveSwarmNodeCmd withSwarmNodeId(@Nonnull String swarmNodeId) {
         checkNotNull(swarmNodeId, "swarmNodeId was not specified");
         this.swarmNodeId = swarmNodeId;
         return this;
diff --git a/docker-java-core/src/main/java/com/github/dockerjava/core/exec/LogContainerCmdExec.java b/docker-java-core/src/main/java/com/github/dockerjava/core/exec/LogContainerCmdExec.java
@@ -32,6 +32,10 @@ protected Void execute0(LogContainerCmd command, ResultCallback<Frame> resultCal
             webTarget = webTarget.queryParam("since", command.getSince());
         }
 
+        if (command.getUntil() != null) {
+            webTarget = webTarget.queryParam("until", command.getUntil());
+        }
+
         webTarget = booleanQueryParam(webTarget, "timestamps", command.hasTimestampsEnabled());
         webTarget = booleanQueryParam(webTarget, "stdout", command.hasStdoutEnabled());
         webTarget = booleanQueryParam(webTarget, "stderr", command.hasStderrEnabled());
diff --git a/docker-java-core/src/main/java/com/github/dockerjava/core/util/CompressArchiveUtil.java b/docker-java-core/src/main/java/com/github/dockerjava/core/util/CompressArchiveUtil.java
@@ -98,7 +98,8 @@ public static File archiveTARFiles(File base, Iterable<File> files, String archi
         tarFile.deleteOnExit();
         try (TarArchiveOutputStream tos = new TarArchiveOutputStream(new GZIPOutputStream(new BufferedOutputStream(
                 new FileOutputStream(tarFile))))) {
-            tos.setLongFileMode(TarArchiveOutputStream.LONGFILE_GNU);
+            tos.setLongFileMode(TarArchiveOutputStream.LONGFILE_POSIX);
+            tos.setBigNumberMode(TarArchiveOutputStream.BIGNUMBER_POSIX);
             for (File file : files) {
                 // relativize with method using Path otherwise method with File resolves the symlinks
                 // and this is not want we want. If the file is a symlink, the relativized path should
diff --git a/docker-java/src/test/java/com/github/dockerjava/cmd/LogContainerCmdIT.java b/docker-java/src/test/java/com/github/dockerjava/cmd/LogContainerCmdIT.java
@@ -206,6 +206,7 @@ public void asyncLogContainerWithSince() throws Exception {
                 .withStdErr(true)
                 .withStdOut(true)
                 .withSince(timestamp)
+                .withUntil(timestamp + 1000)
                 .exec(loggingCallback);
 
         loggingCallback.awaitCompletion();
diff --git a/docker-java/src/test/java/com/github/dockerjava/cmd/swarm/RemoveSwarmNodeCmdExecIT.java b/docker-java/src/test/java/com/github/dockerjava/cmd/swarm/RemoveSwarmNodeCmdExecIT.java
@@ -0,0 +1,44 @@
+package com.github.dockerjava.cmd.swarm;
+
+import com.github.dockerjava.api.DockerClient;
+import com.github.dockerjava.api.model.Swarm;
+import com.github.dockerjava.api.model.SwarmNode;
+import com.github.dockerjava.api.model.SwarmNodeRole;
+import com.google.common.collect.Lists;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+import java.util.Optional;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
+
+public class RemoveSwarmNodeCmdExecIT extends SwarmCmdIT {
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(RemoveSwarmNodeCmdExecIT.class);
+
+    @Test
+    public void testRemoveSwarmNode() throws Exception {
+        DockerClient dockerClient = startSwarm();
+        Swarm swarm = dockerClient.inspectSwarmCmd().exec();
+
+        DockerClient docker2 = startDockerInDocker();
+        docker2.joinSwarmCmd()
+               .withRemoteAddrs(Lists.newArrayList("docker1"))
+               .withJoinToken(swarm.getJoinTokens().getWorker())
+               .exec();
+        LOGGER.info("docker2 joined docker's swarm");
+
+        List<SwarmNode> nodes = dockerClient.listSwarmNodesCmd().exec();
+        assertThat(2, is(nodes.size()));
+        Optional<SwarmNode> firstWorkNode = nodes.stream().filter(node -> node.getSpec().getRole() == SwarmNodeRole.WORKER)
+                                                 .findFirst();
+        dockerClient.removeSwarmNodeCmd(firstWorkNode.get().getId())
+                    .withForce(true)
+                    .exec();
+        nodes = dockerClient.listSwarmNodesCmd().exec();
+        assertThat(nodes.size(), is(1));
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ public ContainerMount withDriver(String driver) {`
`106`	`106`	`*/`
`107`	`107`	`@CheckForNull`
`108`	`108`	`public String getMode() {`
`109`		`- return driver;`
	`109`	`+ return mode;`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`/**`