Remove unused variables

hugares · hugares · commit 6cbe5e2bc413 · 2019-07-08T21:27:18.000-04:00
diff --git a/src/main/java/com/github/dockerjava/core/dockerfile/Dockerfile.java b/src/main/java/com/github/dockerjava/core/dockerfile/Dockerfile.java
@@ -134,8 +134,6 @@ public InputStream buildDockerFolderTar(File directory) {
                 dockerFolderTar = CompressArchiveUtil.archiveTARFiles(directory, filesToAdd,
                         archiveNameWithOutExtension);
 
-                long length = dockerFolderTar.length();
-
                 final FileInputStream tarInputStream = FileUtils.openInputStream(dockerFolderTar);
                 final File tarFile = dockerFolderTar;
 
diff --git a/src/main/java/com/github/dockerjava/core/exec/ExecStartCmdExec.java b/src/main/java/com/github/dockerjava/core/exec/ExecStartCmdExec.java
@@ -1,8 +1,5 @@
 package com.github.dockerjava.core.exec;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import com.github.dockerjava.api.async.ResultCallback;
 import com.github.dockerjava.api.command.ExecStartCmd;
 import com.github.dockerjava.api.model.Frame;
@@ -12,8 +9,6 @@
 
 public class ExecStartCmdExec extends AbstrAsyncDockerCmdExec<ExecStartCmd, Frame> implements ExecStartCmd.Exec {
 
-    private static final Logger LOGGER = LoggerFactory.getLogger(ExecStartCmdExec.class);
-
     public ExecStartCmdExec(WebTarget baseResource, DockerClientConfig dockerClientConfig) {
         super(baseResource, dockerClientConfig);
     }
diff --git a/src/test/java/com/github/dockerjava/cmd/CreateContainerCmdIT.java b/src/test/java/com/github/dockerjava/cmd/CreateContainerCmdIT.java
@@ -906,7 +906,7 @@ public void createContainerFromPrivateRegistryWithValidAuth() throws Exception {
 
     @Test
     public void createContainerFromPrivateRegistryWithNoAuth() throws Exception {
-        AuthConfig authConfig = RegistryUtils.runPrivateRegistry(dockerRule.getClient());
+        RegistryUtils.runPrivateRegistry(dockerRule.getClient());
 
         String imgName = RegistryUtils.createPrivateImage(dockerRule, "create-container-with-no-auth");
 
diff --git a/src/test/java/com/github/dockerjava/cmd/PullImageCmdIT.java b/src/test/java/com/github/dockerjava/cmd/PullImageCmdIT.java
@@ -1,14 +1,11 @@
 package com.github.dockerjava.cmd;
 
-import com.github.dockerjava.api.async.ResultCallback;
 import com.github.dockerjava.api.command.InspectImageResponse;
-import com.github.dockerjava.api.command.PullImageCmd;
 import com.github.dockerjava.api.exception.DockerClientException;
 import com.github.dockerjava.api.exception.InternalServerErrorException;
 import com.github.dockerjava.api.exception.NotFoundException;
 import com.github.dockerjava.api.model.AuthConfig;
 import com.github.dockerjava.api.model.Info;
-import com.github.dockerjava.api.model.PullResponseItem;
 import com.github.dockerjava.core.RemoteApiVersion;
 import com.github.dockerjava.core.command.PullImageResultCallback;
 import com.github.dockerjava.utils.RegistryUtils;
@@ -32,12 +29,6 @@ public class PullImageCmdIT extends CmdIT {
     @Rule
     public ExpectedException exception = ExpectedException.none();
 
-    private static final PullImageCmd.Exec NOP_EXEC = new PullImageCmd.Exec() {
-        public Void exec(PullImageCmd command, ResultCallback<PullResponseItem> resultCallback) {
-            return null;
-        };
-    };
-
     @Test
     public void testPullImage() throws Exception {
         Info info = dockerRule.getClient().infoCmd().exec();
diff --git a/src/test/java/com/github/dockerjava/cmd/UpdateContainerCmdIT.java b/src/test/java/com/github/dockerjava/cmd/UpdateContainerCmdIT.java
@@ -46,7 +46,7 @@ public void updateContainer() throws DockerException, IOException {
         LOG.debug("Inspect: {}", inspectBefore);
         final Long memory = inspectBefore.getHostConfig().getMemory();
 
-        final UpdateContainerResponse updateResponse = dockerRule.getClient().updateContainerCmd(containerId)
+        dockerRule.getClient().updateContainerCmd(containerId)
                 .withBlkioWeight(300)
                 .withCpuShares(512)
                 .withCpuPeriod(100000)
diff --git a/src/test/java/com/github/dockerjava/cmd/swarm/SwarmCmdIT.java b/src/test/java/com/github/dockerjava/cmd/swarm/SwarmCmdIT.java
@@ -34,8 +34,6 @@ public abstract class SwarmCmdIT extends CmdIT {
     private static final int PORT_START = 2378;
     private static final String DOCKER_IN_DOCKER_CONTAINER_PREFIX = "docker";
     private static final String NETWORK_NAME = "dind-network";
-    private static final int MAX_CONNECT_ATTEMPTS = 5;
-    private static final int CONNECT_ATTEMPT_INTERVAL = 200;
     private static final String DOCKER_IN_DOCKER_IMAGE_REPOSITORY = "docker";
     private static final String DOCKER_IN_DOCKER_IMAGE_TAG = "17.12-dind";
 
diff --git a/src/test/java/com/github/dockerjava/core/dockerfile/DockerfileAddMultipleFilesTest.java b/src/test/java/com/github/dockerjava/core/dockerfile/DockerfileAddMultipleFilesTest.java
@@ -2,8 +2,6 @@
 
 import com.google.common.base.Function;
 import org.junit.Test;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import java.io.File;
 import java.io.IOException;
@@ -15,8 +13,6 @@
 
 public class DockerfileAddMultipleFilesTest {
 
-    private static final Logger LOG = LoggerFactory.getLogger(DockerfileAddMultipleFilesTest.class);
-
     private static final Function<File, String> TO_FILE_NAMES = new Function<File, String>() {
         @Override
         public String apply(File file) {
@@ -34,7 +30,7 @@ public void ignoreAllBut() throws Exception {
         assertThat(filesToAdd,
                    containsInAnyOrder("Dockerfile", "foo.jar"));
     }
-    
+
     @Test
     public void nestedDirsPatterns() throws Exception {
         File baseDir = fileFromBuildTestResource("dockerignore/NestedDirsDockerignore");
diff --git a/src/test/java/com/github/dockerjava/core/dockerfile/DockerfileStatementAddTest.java b/src/test/java/com/github/dockerjava/core/dockerfile/DockerfileStatementAddTest.java
@@ -7,8 +7,6 @@
 import org.junit.experimental.runners.Enclosed;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.contains;
@@ -21,8 +19,6 @@ public class DockerfileStatementAddTest {
     @RunWith(Parameterized.class)
     public static final class ParamTests {
 
-        private static final Logger LOG = LoggerFactory.getLogger(DockerfileStatementAddTest.class);
-
         @Parameterized.Parameters(name = "{0} {1} {2}")
         public static Object[][] data() {
             return new Object[][]{{"ADD src dest", contains("src"), "dest"},
diff --git a/src/test/java/com/github/dockerjava/junit/DockerRule.java b/src/test/java/com/github/dockerjava/junit/DockerRule.java
@@ -34,8 +34,6 @@ public class DockerRule extends ExternalResource {
     private DockerClient jerseyClient;
 
     private CmdIT cmdIT;
-    private Object cmdExecFactory;
-
 
     public DockerRule(CmdIT cmdIT) {
         this.cmdIT = cmdIT;
