Handle upstream httpclient changes gracefully

Sineaggi · Sineaggi · commit 3860ea8c693c · 2024-02-12T09:39:33.000-07:00
diff --git a/docker-java-transport-httpclient5/src/main/java/com/github/dockerjava/httpclient5/ApacheDockerHttpClientImpl.java b/docker-java-transport-httpclient5/src/main/java/com/github/dockerjava/httpclient5/ApacheDockerHttpClientImpl.java
@@ -38,6 +38,7 @@
 import javax.net.ssl.SSLContext;
 import java.io.IOException;
 import java.io.InputStream;
+import java.net.InetSocketAddress;
 import java.net.Socket;
 import java.net.URI;
 import java.time.Duration;
@@ -147,17 +148,31 @@ private Registry<ConnectionSocketFactory> createConnectionSocketFactoryRegistry(
         return socketFactoryRegistryBuilder
             .register("tcp", PlainConnectionSocketFactory.INSTANCE)
             .register("http", PlainConnectionSocketFactory.INSTANCE)
-            .register("unix", new PlainConnectionSocketFactory() {
+            .register("unix", new ConnectionSocketFactory() {
                 @Override
                 public Socket createSocket(HttpContext context) throws IOException {
                     return UnixSocket.get(dockerHost.getPath());
                 }
+
+                @Override
+                public Socket connectSocket(TimeValue timeValue, Socket socket, HttpHost httpHost, InetSocketAddress inetSocketAddress,
+                                            InetSocketAddress inetSocketAddress1, HttpContext httpContext) throws IOException {
+                    return PlainConnectionSocketFactory.INSTANCE.connectSocket(timeValue, socket, httpHost, inetSocketAddress,
+                        inetSocketAddress1, httpContext);
+                }
             })
-            .register("npipe", new PlainConnectionSocketFactory() {
+            .register("npipe", new ConnectionSocketFactory() {
                 @Override
                 public Socket createSocket(HttpContext context) {
                     return new NamedPipeSocket(dockerHost.getPath());
                 }
+
+                @Override
+                public Socket connectSocket(TimeValue timeValue, Socket socket, HttpHost httpHost, InetSocketAddress inetSocketAddress,
+                                            InetSocketAddress inetSocketAddress1, HttpContext httpContext) throws IOException {
+                    return PlainConnectionSocketFactory.INSTANCE.connectSocket(timeValue, socket, httpHost, inetSocketAddress,
+                        inetSocketAddress1, httpContext);
+                }
             })
             .build();
     }
