Stabilize tests

bsideup · bsideup · commit 37ddf09520ad · 2020-05-24T10:27:48.000+02:00
diff --git a/docker-java/src/test/java/com/github/dockerjava/cmd/swarm/ListTasksCmdExecIT.java b/docker-java/src/test/java/com/github/dockerjava/cmd/swarm/ListTasksCmdExecIT.java
@@ -51,8 +51,10 @@ public void testListTasks() throws DockerException {
                 .exec();
         String serviceId = response.getId();
         //filtering with service id
-        List<Task> tasks = dockerRule.getClient().listTasksCmd().withServiceFilter(serviceId).exec();
-        assertThat(tasks, hasSize(2));
+        List<Task> tasks = await().until(
+            () -> dockerRule.getClient().listTasksCmd().withServiceFilter(serviceId).exec(),
+            hasSize(2)
+        );
         String taskId = tasks.get(0).getId();
         String secondTaskId = tasks.get(1).getId();
         //filtering with unique id
diff --git a/docker-java/src/test/java/com/github/dockerjava/cmd/swarm/UpdateSwarmServiceIT.java b/docker-java/src/test/java/com/github/dockerjava/cmd/swarm/UpdateSwarmServiceIT.java
@@ -14,6 +14,7 @@
 import java.util.Arrays;
 import java.util.List;
 
+import static org.awaitility.Awaitility.await;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.is;
 
@@ -31,15 +32,16 @@ public void testUpdateServiceReplicate() throws Exception {
                 .withNetworks(Lists.newArrayList(new NetworkAttachmentConfig().withTarget(networkId)))
                 .withName("worker");
         String serviceId = dockerRule.getClient().createServiceCmd(serviceSpec).exec().getId();
-        //list the service
-        List<Service> services = dockerRule.getClient().listServicesCmd().withIdFilter(Arrays.asList(serviceId)).exec();
-        assertThat(services.size(), is(1));
-        Service service = services.get(0);
-        ServiceSpec updateServiceSpec = service.getSpec()
+        await().untilAsserted(() -> {
+            List<Service> services = dockerRule.getClient().listServicesCmd().withIdFilter(Arrays.asList(serviceId)).exec();
+            assertThat(services.size(), is(1));
+            Service service = services.get(0);
+            ServiceSpec updateServiceSpec = service.getSpec()
                 .withMode(new ServiceModeConfig().withReplicated(new ServiceReplicatedModeOptions().withReplicas(2)));
-        dockerRule.getClient().updateServiceCmd(service.getId(), updateServiceSpec).withVersion(service.getVersion().getIndex()).exec();
-        //verify the replicate
-        Service updateService = dockerRule.getClient().listServicesCmd().withIdFilter(Arrays.asList(serviceId)).exec().get(0);
-        assertThat(updateService.getSpec().getMode().getReplicated().getReplicas(), is(2L));
+            dockerRule.getClient().updateServiceCmd(service.getId(), updateServiceSpec).withVersion(service.getVersion().getIndex()).exec();
+            //verify the replicate
+            Service updateService = dockerRule.getClient().listServicesCmd().withIdFilter(Arrays.asList(serviceId)).exec().get(0);
+            assertThat(updateService.getSpec().getMode().getReplicated().getReplicas(), is(2L));
+        });
     }
 }
