Remove console.Terminal check and use IsTerminal from streams.Out
#11934
+17
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh, I didn't notice, there's already #11933 |
docker/cli v27 changed the return value of `Err()` to `streams.Out` which made the typecheck for `console.File` fail. The check is no longer needed due to the `IsTerminal` method present in `streams.Out` which also has a special handling for Windows console. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Remove
console.Terminalcheck and useIsTerminalfromstreams.Outdocker/cli v27 changed the return value of
Err()tostreams.Outwhich made the typecheck for
console.Filefail.The check is no longer needed due to the
IsTerminalmethod present instreams.Outwhich also has a special handling for Windows console.Related issue
fixes #11928
(not mandatory) A picture of a cute animal, if possible in relation to what you did