fix terminal console check #11933
Closed
fix terminal console check #11933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
fix-ansi-output-display
branch
2 times, most recently
from
76bc161 to
756a404
Compare
this was broken by cli v27 release and usage of stream writer for the stderr the new type encapsulates the io.Writer and don't pass the console.File type assertion Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
fix-ansi-output-display
branch
from
756a404 to
876625c
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Contributor
Author
|
Close in favor of #11934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was broken by cli v27 release and usage of stream writer for the stderr the new type encapsulates the io.Writer and don't pass the console.File type assertion
What I did
Introduce the check of the console in Compose code (for windows terminal)
Related issue
fixes #11928
(not mandatory) A picture of a cute animal, if possible in relation to what you did
