fix: use unicode error symbol � instead of failing to import data#2296
Open
spodlesny wants to merge 1 commit intodoccano:masterfrom
Open
fix: use unicode error symbol � instead of failing to import data#2296spodlesny wants to merge 1 commit intodoccano:masterfrom
spodlesny wants to merge 1 commit intodoccano:masterfrom
Conversation
Apply Sweep Rules to your PR?
|
Author
|
Let me know if I should open and new Issue in bug tracker first. I had to fix it for my use-case, so I wanted to share my fix with community in case other have the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding detection is not a silver bullet, and some files can be broken inside, which ends up failing to import the whole batch of files (due to one broken file). For some tasks (sentiment detection), missing character is worth tradeoff. For other use-cases, at least the issue with encoding is presented to user in standardized way and on front-end - without looking into code, like I had to.
Replacement of null character (
\x00) for � is required to successfully save data into PostgreSQL.