Skip to content

feat(v2): add 3d data handling#925

Merged
samsja merged 38 commits into
feat-rewrite-v2from
feat-add-3d-docs-v2
Dec 14, 2022
Merged

feat(v2): add 3d data handling#925
samsja merged 38 commits into
feat-rewrite-v2from
feat-add-3d-docs-v2

Conversation

@anna-charlotte

@anna-charlotte anna-charlotte commented Dec 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Goals:

  • add MeshUrl
  • add tests for MeshUrl
  • add PointCloudUrl
  • add tests for PointCloudUrl
  • add predefined Mesh Document
  • add predefined PointCloud Document
  • check and update documentation, if required. See guide

@anna-charlotte anna-charlotte changed the base branch from main to feat-rewrite-v2 December 9, 2022 13:39
test: add test for mesh url
c20c09e 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
chore: add trimesh to pyproject toml as mesh extra
a5f195e 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
feat: add mesh url class
63fac18 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
anna-charlotte added 11 commits December 9, 2022 15:16
fix: apply mypy fix regarding trimesh
1bde60c 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
fix: apply mypy fix regarding trimesh
c84a86b 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
fix: add trimesh import
f1997db 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
fix: remove timeout param
f90616a 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
test: adjust mesh tests
a0dccb9 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
test: add test for point cloud url
ebbe933 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
feat: add point cloud url
fdcb700 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
fix: np ndarray type hint in point cloud url load
af30bdf 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
feat: add validate function for mesh and point cloud
ad91635 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
chore: exclude trimesh from typechecking
a810623 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
feat: add to node protobuf
d9d9746 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
anna-charlotte added 2 commits December 12, 2022 12:05
test: add tests for validation and protobuf
2e3ed25 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
test: add integration tests for point cloud mesh url
3d548da 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
anna-charlotte added 3 commits December 12, 2022 14:38
feat: add predefined documents for mesh and point cloud
0a13ff2 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
refactor: clean up
b1896a2 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
test: add tests for predefined mesh and point cloud
18f00ca 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
JohannesMessner
JohannesMessner requested changes Dec 12, 2022
View reviewed changes
Comment thread docarray/predefined_document/mesh.py Outdated
anna-charlotte added 3 commits December 12, 2022 16:46
refactor: rename mesh and point cloud class
41f878b 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
fix: apply suggestion
cd65149 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
test: extract toydatadir
c48b357 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
samsja
samsja reviewed Dec 12, 2022
View reviewed changes
Comment thread pyproject.toml
anna-charlotte added 11 commits December 13, 2022 09:33
chore: remove pillow types to check mypy ci check
a10aee0 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
chore: update poetry lock
80bae58 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
chore: revert the two previous commits
fee3f3b 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
docs: add more information to mesh and pc docstrings
2380875 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
fix: fix toy data dir
4b6ca41 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
feat: introduce abstract class url3d
25723de 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
fix: remove abstract load method from url3d class
c965c1d 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
fix: add typehints
73ee853 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
fix: add typehints
d125d96 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Merge branch 'feat-rewrite-v2' into feat-add-3d-docs-v2
793449d 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
feat: update proto pb2
b25aa99 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
@JohannesMessner JohannesMessner mentioned this pull request Dec 13, 2022
Closed
47 tasks
samsja
samsja reviewed Dec 14, 2022
View reviewed changes
Comment thread docarray/typing/url/url_3d/mesh_url.py Outdated
@samsja
fix: apply suggestion
d3e97e2 
Co-authored-by: samsja <55492238+samsja@users.noreply.github.com>
Signed-off-by: Charlotte Gerhaher <charlotte.gerhaher@jina.ai>
JohannesMessner
JohannesMessner requested changes Dec 14, 2022
View reviewed changes

@JohannesMessner JohannesMessner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, can you adjust the class docstrings for MeshUrl, PointCloudUrl, and Url3d? Right now they all say the same thing, as a user which one should I use when? Or is it self-explanatory for someone that (unlike me) knows what they are doing with 3D stuff?

anna-charlotte added 2 commits December 14, 2022 10:46
docs: add more information to 3d url docstrings
32d0b67 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
fix: import in test mesh url
a16b9a6 
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
@anna-charlotte

anna-charlotte commented Dec 14, 2022

Copy link
Copy Markdown
Contributor Author

Ok, added a little bit more information to the docstring

@github-actions

github-actions Bot commented Dec 14, 2022

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-add-3d-docs-v2--jina-docs.netlify.app 🎉

@samsja samsja merged commit dedd18e into feat-rewrite-v2 Dec 14, 2022
@samsja samsja deleted the feat-add-3d-docs-v2 branch December 14, 2022 10:37
@samsja samsja mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohannesMessner JohannesMessner JohannesMessner approved these changes

@samsja samsja samsja approved these changes

Assignees

No one assigned

Labels

area/core area/entrypoint area/setup area/testing area/typing component/document component/proto size/l

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add 3d predefined documents in v2

3 participants

@anna-charlotte @JohannesMessner @samsja