fix: keep offset2id updated when deleting in sqlite - #471
Merged
Conversation
JoanFM
requested changes
Aug 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 83.33% 86.72% +3.39%
==========================================
Files 134 134
Lines 6516 6541 +25
==========================================
+ Hits 5430 5673 +243
+ Misses 1086 868 -218
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JohannesMessner
marked this pull request as ready for review
August 4, 2022 12:38
JoanFM
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the bug described here: #470