Skip to content

fix(array): remove the support of singleton boolean index #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanxiao merged 1 commit into from
Jan 11, 2022
Merged

fix(array): remove the support of singleton boolean index #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docarray/array/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def __setitem__(
index: 'DocumentArrayIndexType',
value: Union['Document', Sequence['Document']],
):
if isinstance(index, (int, np.generic)):
if isinstance(index, (int, np.generic)) and not isinstance(index, bool):
index = int(index)
self._data[index] = value
self._id2offset[value.id] = index
Expand Down Expand Up @@ -289,7 +289,7 @@ def __setitem__(
raise IndexError(f'Unsupported index type {typename(index)}: {index}')

def __delitem__(self, index: 'DocumentArrayIndexType'):
if isinstance(index, (int, np.generic)):
if isinstance(index, (int, np.generic)) and not isinstance(index, bool):
index = int(index)
self._id2offset.pop(self._data[index].id)
del self._data[index]
Expand Down
6 changes: 6 additions & 0 deletions tests/unit/array/test_advance_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,5 +229,11 @@ def test_single_boolean_and_padding():
with pytest.raises(IndexError):
da[True]

with pytest.raises(IndexError):
da[True] = Document()

with pytest.raises(IndexError):
del da[True]

assert len(da[True, False]) == 1
assert len(da[False, False]) == 0