Skip to content

fix: del remove attribute#304

Merged
hanxiao merged 2 commits intomainfrom
fix-delitem-ellipsis
Apr 27, 2022
Merged

fix: del remove attribute#304
hanxiao merged 2 commits intomainfrom
fix-delitem-ellipsis

Conversation

@davidbp
Copy link
Copy Markdown
Contributor

@davidbp davidbp commented Apr 27, 2022

This should cover #303

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 27, 2022

Codecov Report

Merging #304 (faeba5e) into main (5489b69) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   86.50%   86.50%           
=======================================
  Files         134      134           
  Lines        6314     6315    +1     
=======================================
+ Hits         5462     5463    +1     
  Misses        852      852           
Flag Coverage Δ
docarray 86.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/helper.py 82.91% <ø> (ø)
docarray/__init__.py 100.00% <100.00%> (ø)
docarray/array/mixins/delitem.py 86.95% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5161d7f...faeba5e. Read the comment docs.

@davidbp davidbp marked this pull request as ready for review April 27, 2022 10:00
@hanxiao hanxiao linked an issue Apr 27, 2022 that may be closed by this pull request
@hanxiao hanxiao merged commit 363a2fd into main Apr 27, 2022
@hanxiao hanxiao deleted the fix-delitem-ellipsis branch April 27, 2022 12:08
davidbp added a commit that referenced this pull request Apr 28, 2022
* fix: del remove attribute

* test: add test that covers fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

del cleans onlly unique documents

3 participants