Skip to content

fix: improve mesh data loading #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanxiao merged 1 commit into from
Jan 11, 2022
+13 −10
Merged

fix: improve mesh data loading #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions docarray/document/mixins/mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,17 @@ def load_uri_to_point_cloud_blob(
"""
import trimesh

mesh = trimesh.load_mesh(self.uri).deduplicated()

pcs = []
for geo in mesh.geometry.values():
geo: trimesh.Trimesh
pcs.append(geo.sample(samples))

if as_chunks:
from .. import Document

for p in pcs:
self.chunks.append(Document(blob=p))
# try to coerce everything into a scene
scene = trimesh.load(self.uri, force='scene')
for geo in scene.geometry.values():
geo: trimesh.Trimesh
self.chunks.append(Document(blob=geo.sample(samples)))
else:
self.blob = np.stack(pcs).squeeze()
# combine a scene into a single mesh
mesh = trimesh.load(self.uri, force='mesh')
self.blob = mesh.sample(samples)

return self
4 changes: 4 additions & 0 deletions tests/unit/document/test_converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,3 +234,7 @@ def test_glb_converters():
doc = Document(uri=os.path.join(cur_dir, 'toydata/test.glb'))
doc.load_uri_to_point_cloud_blob(2000)
assert doc.blob.shape == (2000, 3)

doc.load_uri_to_point_cloud_blob(2000, as_chunks=True)
assert len(doc.chunks) == 1
assert doc.chunks[0].blob.shape == (2000, 3)