Skip to content

docs: fix sign commit commad in docs#1834

Merged
JoanFM merged 1 commit into
docarray:mainfrom
ai-naymul:fix-sign-commiting-issue
Dec 4, 2023
Merged

docs: fix sign commit commad in docs#1834
JoanFM merged 1 commit into
docarray:mainfrom
ai-naymul:fix-sign-commiting-issue

Conversation

@ai-naymul

Copy link
Copy Markdown
Contributor

Screenshot_3

The command is not correct in the CONTRIBRUTING.md file
in this commit the command is corrected in the file

@JoanFM

JoanFM commented Dec 2, 2023

Copy link
Copy Markdown
Member

Hey @ai-naymul ,

We need you to sign off the commit

@ai-naymul

Copy link
Copy Markdown
Contributor Author

Hey @ai-naymul ,

We need you to sign off the commit

I hate the DCO, I always forgot to add the sign😪
Let me fix that

@ai-naymul

ai-naymul commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

Hey @ai-naymul ,

We need you to sign off the commit

@JoanFM I am getting the following error would you mind helping me to out this, In tried different methods but didn't work out.
Screenshot_4

@JoanFM

JoanFM commented Dec 4, 2023

Copy link
Copy Markdown
Member

Hey @ai-naymul ,
We need you to sign off the commit

@JoanFM I am getting the following error would you mind helping me to out this, In tried different methods but didn't work out. Screenshot_4

I do not know how to solve it, what if u create a nee PR from a fresh branch with the commit signed off from start

@ai-naymul

ai-naymul commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

Hey @ai-naymul ,
We need you to sign off the commit

@JoanFM I am getting the following error would you mind helping me to out this, In tried different methods but didn't work out. Screenshot_4

I do not know how to solve it, what if u create a nee PR from a fresh branch with the commit signed off from start

I am also getting this error when I try to sign my commit not only for this case

This error is only getting when try to sign commit otherwise commiting is working

@JoanFM

JoanFM commented Dec 4, 2023

Copy link
Copy Markdown
Member

have u googled it?

@JoanFM

JoanFM commented Dec 4, 2023

Copy link
Copy Markdown
Member

@ai-naymul

Copy link
Copy Markdown
Contributor Author

have u googled it?

Yeah tried different methods but didn't solved

@ai-naymul

Copy link
Copy Markdown
Contributor Author

Have u checked here? https://gist.github.com/paolocarrasco/18ca8fe6e63490ae1be23e84a7039374

Let me try it

Signed-off-by: Naymul Islam <naymul504@gmail.com>
@ai-naymul ai-naymul force-pushed the fix-sign-commiting-issue branch from 0077aaf to 475c5d1 Compare December 4, 2023 17:16
@ai-naymul

Copy link
Copy Markdown
Contributor Author

Ahhh.. Finally @JoanFM could you please check is everything fine :)
btw thanks for referring

@JoanFM JoanFM changed the title fix(docs): fix sign commit commad in docs docs: fix sign commit commad in docs Dec 4, 2023
@JoanFM JoanFM merged commit 82918fe into docarray:main Dec 4, 2023
@JoanFM JoanFM mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants