Skip to content

test: remove skips #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 1 commit into from
Sep 28, 2023
Merged

test: remove skips #1809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/units/array/test_array_from_to_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from docarray import BaseDoc, DocList, DocVec
from docarray.documents import ImageDoc
from docarray.typing import NdArray, TorchTensor
from docarray.utils._internal.pydantic import is_pydantic_v2


@pytest.fixture()
Expand Down Expand Up @@ -136,7 +135,6 @@ class BasisUnion(BaseDoc):
assert docs_copy == docs_basic


@pytest.mark.skipif(is_pydantic_v2, reason="Not working with pydantic v2")
@pytest.mark.parametrize('tensor_type', [NdArray, TorchTensor])
def test_from_to_pandas_tensor_type(tensor_type):
class MyDoc(BaseDoc):
Expand Down
1 change: 0 additions & 1 deletion tests/units/document/test_base_document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from docarray import DocList, DocVec
from docarray.base_doc.doc import BaseDoc
from docarray.typing import NdArray
from docarray.utils._internal.pydantic import is_pydantic_v2


def test_base_document_init():
Expand Down
4 changes: 0 additions & 4 deletions tests/units/util/test_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

from docarray import BaseDoc, DocList
from docarray.documents import ImageDoc, TextDoc
from docarray.utils._internal.pydantic import is_pydantic_v2
from docarray.utils.filter import filter_docs


Expand Down Expand Up @@ -244,9 +243,6 @@ def test_logic_filter(docs, dict_api):
assert len(result) == 3


@pytest.mark.skipif(
is_pydantic_v2, reason="Not working with pydantic v2"
) # TextDoc validation with string is not working with pydantic v2
@pytest.mark.parametrize('dict_api', [True, False])
def test_from_docstring(dict_api):
class MyDocument(BaseDoc):
Expand Down