Skip to content

refactor: hide get_attributes to private#18

Merged
hanxiao merged 1 commit intomainfrom
feat-private-get-attri
Jan 10, 2022
Merged

refactor: hide get_attributes to private#18
hanxiao merged 1 commit intomainfrom
feat-private-get-attri

Conversation

@hanxiao
Copy link
Copy Markdown
Member

@hanxiao hanxiao commented Jan 10, 2022

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2022

Codecov Report

Merging #18 (f6e70c0) into main (3573d82) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   82.94%   82.84%   -0.10%     
==========================================
  Files          67       67              
  Lines        3137     3137              
==========================================
- Hits         2602     2599       -3     
- Misses        535      538       +3     
Flag Coverage Δ
docarray 82.84% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/document.py 83.79% <100.00%> (ø)
docarray/array/mixins/getattr.py 81.81% <100.00%> (-9.10%) ⬇️
docarray/array/mixins/plot.py 69.28% <100.00%> (ø)
docarray/document/mixins/attribute.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9112c5a...f6e70c0. Read the comment docs.

@hanxiao hanxiao merged commit e62c1ad into main Jan 10, 2022
@hanxiao hanxiao deleted the feat-private-get-attri branch January 10, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant