Skip to content

refactor: use safe_issubclass #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 1 commit into from
Sep 6, 2023
+2 −2
Merged

refactor: use safe_issubclass #1778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docarray/array/doc_vec/doc_vec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def _check_doc_field_not_none(field_name, doc):

stacked: tf.Tensor = tf.stack(tf_stack)
tensor_columns[field_name] = TensorFlowTensor(stacked)
elif jnp_available and issubclass(field_type, JaxArray):
elif jnp_available and safe_issubclass(field_type, JaxArray):
if first_doc_is_none:
_verify_optional_field_of_docs(docs)
tensor_columns[field_name] = None
Expand Down
2 changes: 1 addition & 1 deletion docarray/typing/tensor/abstract_tensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def __instancecheck__(cls, instance):
for candidate in type(instance).__mro__
)
return any(
issubclass(candidate, cls) for candidate in type(instance).__mro__
safe_issubclass(candidate, cls) for candidate in type(instance).__mro__
)
return super().__instancecheck__(instance)

Expand Down