Skip to content

Commit 75ddeb4

Browse files
author
Joan Fontanals
authored
Merge branch 'main' into pull-stream-file
2 parents 78df9bb + 92de15e commit 75ddeb4

4 files changed

Lines changed: 0 additions & 9 deletions

File tree

tests/integrations/store/test_s3.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from docarray import DocList
99
from docarray.documents import TextDoc
1010
from docarray.store import S3DocStore
11-
from docarray.utils._internal.pydantic import is_pydantic_v2
1211
from tests.integrations.store import gen_text_docs, get_test_da, profile_memory
1312

1413
DA_LEN: int = 2**10
@@ -131,7 +130,6 @@ def test_pushpull_stream_correct(capsys):
131130

132131

133132
# for some reason this test is failing with pydantic v2
134-
@pytest.mark.skipif(is_pydantic_v2, reason="Not working with pydantic v2 for now")
135133
@pytest.mark.slow
136134
def test_pull_stream_vs_pull_full():
137135
namespace_dir = f'{BUCKET}/test{RANDOM}/pull-stream-vs-pull-full'

tests/units/array/test_array_from_to_pandas.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from docarray import BaseDoc, DocList, DocVec
77
from docarray.documents import ImageDoc
88
from docarray.typing import NdArray, TorchTensor
9-
from docarray.utils._internal.pydantic import is_pydantic_v2
109

1110

1211
@pytest.fixture()
@@ -136,7 +135,6 @@ class BasisUnion(BaseDoc):
136135
assert docs_copy == docs_basic
137136

138137

139-
@pytest.mark.skipif(is_pydantic_v2, reason="Not working with pydantic v2")
140138
@pytest.mark.parametrize('tensor_type', [NdArray, TorchTensor])
141139
def test_from_to_pandas_tensor_type(tensor_type):
142140
class MyDoc(BaseDoc):

tests/units/document/test_base_document.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from docarray import DocList, DocVec
77
from docarray.base_doc.doc import BaseDoc
88
from docarray.typing import NdArray
9-
from docarray.utils._internal.pydantic import is_pydantic_v2
109

1110

1211
def test_base_document_init():

tests/units/util/test_filter.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
from docarray import BaseDoc, DocList
77
from docarray.documents import ImageDoc, TextDoc
8-
from docarray.utils._internal.pydantic import is_pydantic_v2
98
from docarray.utils.filter import filter_docs
109

1110

@@ -244,9 +243,6 @@ def test_logic_filter(docs, dict_api):
244243
assert len(result) == 3
245244

246245

247-
@pytest.mark.skipif(
248-
is_pydantic_v2, reason="Not working with pydantic v2"
249-
) # TextDoc validation with string is not working with pydantic v2
250246
@pytest.mark.parametrize('dict_api', [True, False])
251247
def test_from_docstring(dict_api):
252248
class MyDocument(BaseDoc):

0 commit comments

Comments
 (0)