Skip to content

Split DoH Resolver into Java versions, fix initial request and tests #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ibauersachs merged 1 commit into from
Jun 28, 2025
Merged

Split DoH Resolver into Java versions, fix initial request and tests #385

ibauersachs merged 1 commit into from
Jun 28, 2025

Conversation

@ibauersachs
Copy link
Member

@ibauersachs ibauersachs commented Jun 28, 2025 •
edited
Loading

  • Remove reflection and use Multi-Release jar instead
  • Introduce a base class to share the common functionality of all versions
  • Fix initial request handling for Java 11+ version
  • Change tests to use the versions code

@codecov
Copy link

codecov bot commented Jun 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.

Project coverage is 66.24%. Comparing base (7411e13) to head (8d54d90).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/xbill/DNS/DohResolver.java 0.00% 41 Missing ⚠️
src/main/java/org/xbill/DNS/AsyncSemaphore.java 0.00% 15 Missing ⚠️
...n/java/org/xbill/DNS/TimeoutCompletableFuture.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #385      +/-   ##
============================================
- Coverage     66.63%   66.24%   -0.40%     
+ Complexity     3061     3020      -41     
============================================
  Files           198      198              
  Lines         13698    13519     -179     
  Branches       2121     2104      -17     
============================================
- Hits           9128     8955     -173     
- Misses         4005     4016      +11     
+ Partials        565      548      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 28, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ibauersachs ibauersachs merged commit 59eb83b into master Jun 28, 2025
24 of 27 checks passed
@ibauersachs ibauersachs deleted the bugfix/doh-tests branch June 28, 2025 15:18
@ibauersachs ibauersachs added this to the v3.6.4 milestone Jun 28, 2025
@ibauersachs ibauersachs self-assigned this Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ibauersachs ibauersachs

Labels

None yet

Projects

None yet

Milestone

v3.6.4

Development

Successfully merging this pull request may close these issues.

2 participants

@ibauersachs