Add tests to filename space separator sanitization#23
Merged
dmsnell merged 1 commit intodmsnell:filenames/avoid-collation-corruptionfrom Jul 1, 2025
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
commented
Jul 1, 2025
Comment on lines
+42
to
+48
| 'unencoded space.png' => 'unencoded-space.png', | ||
| 'encoded-space.jpg' => 'encoded-space.jpg', | ||
| 'plus+space.jpg' => 'plusspace.jpg', | ||
| 'multi %20 +space.png' => 'multi-20-space.png', | ||
| "Screenshot 2025-02-19 at 2.17.33\u{202F}PM.png" => 'Screenshot-2025-02-19-at-2.17.33-PM.png', | ||
| "Filename with non-breaking\u{00A0}space.txt" => 'Filename-with-non-breaking-space.txt', | ||
| "Filename with thin\u{2009}space.txt" => 'Filename-with-thin-space.txt', |
Collaborator
Author
There was a problem hiding this comment.
I tried to keep this minimal. Ideally, this would be a data provider but that's best left for a follow-up.
3 different space space characters are handled as expected.
dmsnell
merged commit 8ceae7b
into
dmsnell:filenames/avoid-collation-corruption
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some tests for WordPress#9103.
# from repo checkout ./vendor/bin/phpunit --testdox --group=16330If I revert
wp-includes/formatting.phptotrunk's version, the tests fail:This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.