[Example][Bugfix] Fix arma example #4218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
To trigger regression tests:
|
Collaborator
yaox12
reviewed
Jul 7, 2022
examples/pytorch/arma/model.py
Outdated
| output += feats | ||
| return output / self.K | ||
| tot_output = torch.cat((tot_output, output), 0) |
Collaborator
There was a problem hiding this comment.
I'd prefer defining tot_output as a list to store outputs and then calculating their mean by torch.stack(...).mean().
Collaborator
Author
There was a problem hiding this comment.
Okay, I will update accordingly.
Collaborator
yaox12
approved these changes
Jul 8, 2022
Collaborator
Collaborator
BarclayII
pushed a commit
to BarclayII/dgl
that referenced
this pull request
Aug 10, 2022
* Fix arma example * Update Co-authored-by: Xin Yao <xiny@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To fix #4202, the crash due to in-place operations for one variable needed for backward propagation.
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes
At the end of forward function, to compute average output over all stacks, instead of doing
+=(in-place operations) as:output += featuresusing
unsqueeze() + cat()to store all stack outputs and return the mean of them.Additional notes
With profiling, no significant performance penalty observed with this fix (less than 10% slow-down)