Skip to content

Add query_string in Request Model #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamshivam007 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add query_string in Request Model #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6843216
Add query_string in Request Model
Jun 16, 2018
86ebcb3
Add tests for query_string in Request Model
Jun 24, 2018
c337422
Merge branch 'master' into master
iamshivam007 May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion request/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class RequestAdmin(admin.ModelAdmin):
list_display = ('time', 'path', 'response', 'method', 'request_from')
fieldsets = (
(_('Request'), {
'fields': ('method', 'path', 'time', 'is_secure', 'is_ajax')
'fields': ('method', 'path', 'query_string', 'time', 'is_secure', 'is_ajax')
}),
(_('Response'), {
'fields': ('response',)
Expand Down
20 changes: 20 additions & 0 deletions request/migrations/0007_migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# -*- coding: utf-8 -*-
# Generated by Django 1.9.2 on 2018-06-16 11:48
from __future__ import unicode_literals

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('request', '0006_alter_request_method_default'),
]

operations = [
migrations.AddField(
model_name='request',
name='query_string',
field=models.CharField(verbose_name='query string', max_length=255, blank=True),
),
]
2 changes: 2 additions & 0 deletions request/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ class Request(models.Model):
# Request information.
method = models.CharField(_('method'), default='GET', max_length=7)
path = models.CharField(_('path'), max_length=255)
query_string = models.CharField(_('query string'), max_length=255, blank=True)
time = models.DateTimeField(_('time'), default=timezone.now, db_index=True)

is_secure = models.BooleanField(_('is secure'), default=False)
Expand Down Expand Up @@ -57,6 +58,7 @@ def from_http_request(self, request, response=None, commit=True):
# Request information.
self.method = request.method
self.path = request.path[:255]
self.query_string = request.META.get('QUERY_STRING', '')[:255]

self.is_secure = request.is_secure()
self.is_ajax = request.is_ajax()
Expand Down
2 changes: 2 additions & 0 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def test_from_http_request(self):
http_request.META['REMOTE_ADDR'] = '32.64.128.16'
http_request.META['HTTP_USER_AGENT'] = 'test user agent'
http_request.META['HTTP_REFERER'] = 'https://fuller.li/'
http_request.META['QUERY_STRING'] = 'name=abc'

http_response = HttpResponse(status=204)

Expand All @@ -31,6 +32,7 @@ def test_from_http_request(self):
self.assertEqual(request.response, 204)
self.assertEqual(request.user_agent, 'test user agent')
self.assertEqual(request.referer, 'https://fuller.li/')
self.assertEqual(request.query_string, 'name=abc')

def test_from_http_request_with_user(self):
http_request = HttpRequest()
Expand Down