Skip to content

Conversation

@KRRT7
Copy link

@KRRT7 KRRT7 commented Oct 28, 2025

originally found in codeflash-ai#127 but adapted to follow Django code style

@github-actions github-actions bot added the no ticket Based on PR title, no linked Trac ticket label Oct 28, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@KRRT7 KRRT7 changed the title make strip_spaces_between_tags lazy micro optimize strip_spaces_between_tags for speed Oct 28, 2025
@adamchainz
Copy link
Member

I'm not sure this really makes a difference for most usage. The re module caches recently-compiled patterns. The AI-generated explanation on the linked PR missed this fact and it's not clear if the benchmarks used multiple runs of each test.

@ilovelinux
Copy link

@KRRT7 could you provide some benchmarks? That's the foundation for an optimization PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no ticket Based on PR title, no linked Trac ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants