Skip to content

Fixed #36682 -- Prevented RecursionError while search for relations between models #20010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Fixed #36682 -- Prevented RecursionError while search for relations between models #20010

wants to merge 17 commits into from
+12 −0

Conversation

@AugustoPontes1
Copy link
Contributor

@AugustoPontes1 AugustoPontes1 commented Oct 27, 2025 •
edited
Loading

Trac ticket number

ticket-#36682

Branch description

When there are several relations on the Models, a RecursionError happens if you try to query and list them

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

charettes
charettes reviewed Oct 29, 2025
View reviewed changes
Copy link
Member

@charettes charettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you walk us through how you determined this is an adequate solution to the problem?

@AugustoPontes1
Copy link
Contributor Author

AugustoPontes1 commented Oct 31, 2025

I rewrote most part of the code, removing unecessary parts, and making it more simple, and while i was searching for a way to solve this, it seems that the problem is much more deeper than it looks, but i didnt wanted to touch other modules, because its very complex, and i recently joined at this open-source community, so i have a lot to learn, but thanks for your review, and if i need to do more things to get this done, no problem, i accept any advice, including the changes that i made now 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@charettes charettes charettes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AugustoPontes1 @charettes