Fixed #36192 -- Used semantic HTML for buttons. #19995
Open
+229
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Phinart98, I’d like to add you as a co-author, but I don’t know your email address. |
Antoliny0919
added
selenium
6 tasks
Changed ...I tried to preserve the existing style as much as possible.
|
Antoliny0919
force-pushed
the
use_semantic_admin_button
branch
from
1aa9803 to
2bb4d14
Compare
Hello @Antoliny0919 , oh great! My email is phinart98@gmail.com . |
Co-authored-by: Phinart98 <phinart98@gmail.com>
Antoliny0919
force-pushed
the
use_semantic_admin_button
branch
from
2bb4d14 to
3b5d6db
Compare
ilovelinux
suggested changes
Oct 31, 2025
There was a problem hiding this comment.
The role="button" attribute should be kept in those <a> elements that still act as a button but can't be replaced with a <button> element since it's used for accessibility1.
Footnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36192
Branch description
Continue PR..
Thank you for the work you did on this @Phinart98 🚀
I removed the
role="button"attributes from the<a>elements and converted the appropriate<a>tags to<button>tags where a button element was more suitable.Checklist
mainbranch.