DEV: Remove the legacy widget code #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate obsolete `post-stream:refresh` event triggers. These events were marked as TODO for removal after the Glimmer migration and are no longer needed. This cleanup improves code clarity and reduces unnecessary event emissions, with no impact on functionality since the events were unused by the current post-stream implementation.
Remove usages of `glimmer_post_stream_mode` in tests across various files, including acceptance and system-level specs, where it was used to toggle testing behavior. This reduces test complexity and ensures coverage without dependency on this feature flag, which is being phased out.
megothss
changed the title
Remove deprecated `discourse.post-stream-widget-overrides` and associated legacy widget customizations. This cleanup reduces technical debt, ensures future maintainability, and aligns with the latest framework improvements.
Add compatibility entry for `< 3.6.0.beta3-latest` in the `.discourse-compatibility` file to align with recent core version changes. This ensures the plugin remains compatible with updated core version requirements and avoids potential mismatches during use.
davidtaylorhq
approved these changes
Nov 21, 2025
Adjust the `.discourse-compatibility` file to reflect compatibility with `< 2025.12.0-latest`, ensuring the plugin aligns with upcoming core versioning changes. This update preempts potential mismatches and maintains plugin functionality with evolving Discourse core updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate obsolete
post-stream:refreshevent triggers. These events were marked as TODO for removal after the Glimmer migration and are no longer needed.This cleanup improves code clarity and reduces unnecessary event emissions, with no impact on functionality since the events were unused by the current post-stream implementation.