FIX: Warn moderators before group changes that would lock them out #36811
+292
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moderators (with `moderators_manage_groups` enabled) change a group's visibility or members visibility to "Owners only" while not being an owner themselves, they would permanently lose access to manage that group. Similarly, removing themselves as owner when visibility is set to "Owners only" would lock them out. This adds confirmation dialogs warning moderators before: - Changing group visibility to "Owners only" - Changing members visibility to "Owners only" - Removing themselves as owner when visibility is restrictive - Removing themselves as member when they're also an owner Also refactors the category lockout code from PR #36663 to use async/await for consistency. Ref: https://meta.discourse.org/t/391403 Ref: #36663
github-actions
bot
added
the
i18n
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/moderators-can-change-groups-such-that-they-lose-access/391403/3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moderators (with
moderators_manage_groupsenabled) change a group's visibility or members visibility to "Owners only" while not being an owner themselves, they would permanently lose access to manage that group. Similarly, removing themselves as owner when visibility is set to "Owners only" would lock them out.This adds confirmation dialogs warning moderators before:
Also refactors the category lockout code from PR #36663 to use async/await for consistency.
Ref: https://meta.discourse.org/t/391403