FIX: new DM channels not being published #36799
Open
+31
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to "new DM" not showing up in sidebar till you reload
Member
Author
|
this failure has got to be a flake... will try to fix it |
DMs get "auto followed" when users get a new message which will trigger sidebar
|
|
||
| it "shows the channel in the sidebar without reload" do | ||
| visit("/") | ||
| chat_sidebar = PageObjects::Components::Chat::Sidebar.new |
Contributor
There was a problem hiding this comment.
minor nit, is that we usually put page objects in a let!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting following to "false" on new DM channels it mirrors what happens when you hit X on a channel, that way the first message will trigger showing the channel to the missing users