DEV: Allow new instances to be set up directly with Discourse ID #36731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
i18n
ZogStriP
reviewed
Dec 17, 2025
| def visit_index | ||
| visit("/finish-installation") | ||
| def has_discourse_id_button? | ||
| page.has_css?(".finish-installation__discourse-id", text: "Login with Discourse ID") |
Member
There was a problem hiding this comment.
Should the "text:" use I18n instead?
Contributor
Author
There was a problem hiding this comment.
I think it's clearer without I18n personally... we use both in core afaik.
ZogStriP
reviewed
Dec 17, 2025
ZogStriP
reviewed
Dec 17, 2025
ZogStriP
reviewed
Dec 17, 2025
ZogStriP
reviewed
Dec 17, 2025
ZogStriP
reviewed
Dec 17, 2025
ZogStriP
reviewed
Dec 17, 2025
ZogStriP
reviewed
Dec 17, 2025
ZogStriP
reviewed
Dec 17, 2025
Contributor
Author
|
I think I addressed you main comments here @ZogStriP, can you give this another look. |
ZogStriP
reviewed
Dec 18, 2025
ZogStriP
reviewed
Dec 18, 2025
ZogStriP
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on discourse/discourse_docker#1010
When email setup is skipped, we can register the site for Discourse ID. That means the admin (and other users), can signup/login without the site having working email at all. The goal of this feature is to simplify bootstrapping a test site. A well-functioning community will likely need working email at some point, this simplifies the first step of getting started.
Screenshot when ID auth is available:
Screenshots when setup cannot continue: