DEV: replace hashtag autocomplete templates with components #35829
+184
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
force-pushed
the
dev-replace-hashtag-autocomplete-template-with-component
branch
from
a3d1075 to
d1ee8a2
Compare
Comment on lines
+19
to
+24
| * @component HashtagAutocompleteResults | ||
| * @param {Array} results - Array of autocomplete results (categories and tags) | ||
| * @param {number} selectedIndex - Currently selected index in the results list | ||
| * @param {Function} onSelect - Callback function triggered when a result is selected | ||
| * @param {Function} onRender - Optional callback function triggered after component renders | ||
| */ |
There was a problem hiding this comment.
BTW, there is an official JSDoc syntax to document components which we're playing with (e.g.). If an editor is configured correctly, it can provide autocomplete/docs for arguments.
Not a blocker for this PR - we have a ton of non-standard-jsdoc comments on other components. Just thought you might be interested.
davidtaylorhq
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #35539. This replaces template args used for applying the autocomplete modifier for handling
#triggers to autocomplete categories.