FIX: Set invited PM users to watch so they receive notifications #35722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user is invited to an existing private message, they were not receiving notifications for subsequent messages. This occurred because `TopicUser` records are created lazily when a user first visits a topic, but `PostAlerter#notify_pm_users` checks the notification level immediately when determining who should receive notifications. This patch explicitly creates a `TopicUser` record with its notification level set to `watching` immediately after granting PM access, ensuring the invited user receives notifications for all subsequent messages even before their first visit.
Flink
force-pushed
the
loic/watch-pm-when-invited
branch
from
6885bd8 to
4485c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user is invited to an existing private message, they were not receiving notifications for subsequent messages. This occurred because
TopicUserrecords are created lazily when a user first visits a topic, butPostAlerter#notify_pm_userschecks the notification level immediately when determining who should receive notifications.This PR explicitly creates a
TopicUserrecord with its notification level set towatchingimmediately after granting PM access, ensuring the invited user receives notifications for all subsequent messages even before their first visit.