-
Notifications
You must be signed in to change notification settings - Fork 8.8k
FIX: extract and fix overriding of usernames by external auth #14637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschlager
requested changes
Oct 18, 2021
gschlager
requested changes
Nov 16, 2021
gschlager
approved these changes
Nov 18, 2021
ZogStriP
approved these changes
Nov 19, 2021
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/updating-mentions-when-username-is-changed-via-sso/202992/3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses comments of @gschlager to #14531:
discourse/app/models/user.rb
Lines 1441 to 1443 in 78cfaa6
UsernameChangerinstead of just setting a new username in order to update quotes and mentions when renaming (which addresses this complaint https://meta.discourse.org/t/updating-mentions-when-username-is-changed-via-sso/202992)