Fetch upstream with feathers-objection:master#12
Open
FaizuddinEverest wants to merge 1 commit intodinode:masterfrom
Open
Fetch upstream with feathers-objection:master#12FaizuddinEverest wants to merge 1 commit intodinode:masterfrom
FaizuddinEverest wants to merge 1 commit intodinode:masterfrom
Conversation
estephan
reviewed
Nov 23, 2021
|
|
||
| // $select uses a specific find syntax, so it has to come first. | ||
| if (filters.$select) { | ||
| q.select(...filters.$select.concat(`${this.Model.tableName}.${this.id}`)); |
There was a problem hiding this comment.
Maybe just double check we didn't make this change.
|
|
||
| if (query && query.$joinRelation) { | ||
| q | ||
| .distinct(`${this.Model.tableName}.*`) |
|
|
||
| return newObject; | ||
| }); | ||
| return this._createQuery(params) |
There was a problem hiding this comment.
Can you please look into this and see if this._createQuery should be this.createQuery.
| } | ||
|
|
||
| const q = this.createQuery(params); | ||
| const q = this._createQuery(params); |
There was a problem hiding this comment.
I think we shouldn't make this change 🤔
|
|
||
| const { query: queryParams } = this.filterQuery(params); | ||
| const query = this.createQuery(params); | ||
| const query = this._createQuery(params); |
There was a problem hiding this comment.
I think it should be createQuery without the _.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.