Skip to content

Commit cd490b6

Browse files
octoperoctoper
authored
chore(tanstack-start): Fix types for createClerkHandler (clerk#4081)
1 parent 1dc1cb7 commit cd490b6

3 files changed

Lines changed: 11 additions & 6 deletions

File tree

‎.changeset/four-experts-learn.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@clerk/tanstack-start": patch
3+
---
4+
5+
Types fix for `createClerkHandler`

‎packages/tanstack-start/src/client/ClerkProvider.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ const SDK_METADATA = {
1818
const awaitableNavigateRef: { current: ReturnType<typeof useAwaitableNavigate> | undefined } = { current: undefined };
1919

2020
export function ClerkProvider({ children, ...providerProps }: TanstackStartClerkProviderProps): JSX.Element {
21+
const awaitableNavigate = useAwaitableNavigate();
2122
const routerContext = useRouteContext({
2223
strict: false,
2324
});
24-
const awaitableNavigate = useAwaitableNavigate();
2525

2626
useEffect(() => {
2727
awaitableNavigateRef.current = awaitableNavigate;

‎packages/tanstack-start/src/server/middlewareHandler.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,18 @@ import { loadOptions } from './loadOptions';
66
import type { LoaderOptions } from './types';
77
import { getResponseClerkState } from './utils';
88

9-
export type RequestHandler<TRouter extends AnyRouter> = (ctx: {
9+
export type HandlerCallback<TRouter extends AnyRouter> = (ctx: {
1010
request: Request;
1111
router: TRouter;
1212
responseHeaders: Headers;
13-
}) => Promise<Response>;
14-
export type CustomizeRequestHandler<TRouter extends AnyRouter> = (cb: RequestHandler<TRouter>) => EventHandler;
13+
}) => Response | Promise<Response>;
14+
export type CustomizeStartHandler<TRouter extends AnyRouter> = (cb: HandlerCallback<TRouter>) => EventHandler;
1515

1616
export function createClerkHandler<TRouter extends AnyRouter>(
17-
eventHandler: CustomizeRequestHandler<TRouter>,
17+
eventHandler: CustomizeStartHandler<TRouter>,
1818
clerkOptions: LoaderOptions = {},
1919
) {
20-
return (cb: RequestHandler<TRouter>): EventHandler => {
20+
return (cb: HandlerCallback<TRouter>): EventHandler => {
2121
return eventHandler(async ({ request, router, responseHeaders }) => {
2222
try {
2323
const loadedOptions = loadOptions(request, clerkOptions);

0 commit comments

Comments
 (0)