Customize artifact of google java format#944
Conversation
figroc
changed the title
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
Happy to merge this, needs:
- misc changes which I marked up inline
- a teensy callout within the README for plugin-gradle and plugin-maven
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/JavaExtension.java
Outdated
Show resolved
Hide resolved
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/JavaExtension.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/diffplug/spotless/java/GoogleJavaFormatStep.java
Outdated
Show resolved
Hide resolved
|
@nedtwigg Thank you for your insight. Should I keep the |
|
Yes please :) |
|
@nedtwigg Would you take another look? |
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
Just a few nits and I think this can get merged. You need it, and that's good enough for it to get merged.
What I don't like about it is that I think this feature is very niche, and not many people will need it. In general, I think it's good to gate stuff like that behind a custom name to indicate "you probably don't need this if you're just exploring". But maybe I'm wrong, and there are more forked GJF versions out there than I realize. So I'm okay with the naming and API as-is.
I'd like to let this cool off for 48 hrs to see if any other maintainers want to weigh-in, then I'll merge and release.
lib/src/main/java/com/diffplug/spotless/java/GoogleJavaFormatStep.java
Outdated
Show resolved
Hide resolved
|
This looks great, all my concerns are satisfied. I'll merge and release sometime Thursday unless somebody objects between now and then. |
|
@nedtwigg I forgot to add test for the feature. Please wait for my update. |
|
@nedtwigg done adding unit tests |
figroc
force-pushed
the
feat-gjf-artifact
branch
from
b778a4b to
6757a42
Compare
|
@nedtwigg I've rebased the PR. It seems there is some problem with |
|
Sorry, I'm stalled on #950. You've gone your part, I'll do mine asap. |
|
Please merge the latest |
update change log add new ctor of State instead of changing existed ones change artifact to groupArtifact check groupArtifact content add tests for custom group artifact
figroc
force-pushed
the
feat-gjf-artifact
branch
from
6757a42 to
c478183
Compare
|
Published in |
|
FYI, |
2 participants
Add
artifactoption toGoogleJavaFormatStep.The Google Java Format is not friendly for lambda. I've managed a customized artifact to improve it. This PR allows user to integrate home-brewed GJF with spotless.