allow "spotlessFiles" project property in gradle plugin to only target specific files#322
Merged
nedtwigg merged 6 commits intodiffplug:masterfrom Dec 13, 2018
vmdominguez:specify-files
Merged
allow "spotlessFiles" project property in gradle plugin to only target specific files#322nedtwigg merged 6 commits intodiffplug:masterfrom vmdominguez:specify-files
nedtwigg merged 6 commits intodiffplug:masterfrom
vmdominguez:specify-files
Conversation
JLLeitschuh
reviewed
Dec 11, 2018
thc202
reviewed
Dec 11, 2018
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java
Outdated
Show resolved
Hide resolved
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java
Outdated
Show resolved
Hide resolved
- update change log to reflect namespaced property - remove superfluous assert statement - compile Patterns once
nedtwigg
requested changes
Dec 12, 2018
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks great except for a very subtle bug that's pretty easy to fix.
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java
Outdated
Show resolved
Hide resolved
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java
Outdated
Show resolved
Hide resolved
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java
Outdated
Show resolved
Hide resolved
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java
Show resolved
Hide resolved
vmdominguez
changed the title
nedtwigg
reviewed
Dec 12, 2018
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java
Outdated
Show resolved
Hide resolved
nedtwigg
reviewed
Dec 12, 2018
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java
Outdated
Show resolved
Hide resolved
Member
|
This LGTM. I'll cut a release tomorrow unless somebody has more comments or another PR they'd like to get merged in. |
nedtwigg
approved these changes
Dec 12, 2018
Member
|
Published as 3.17.0 |
Merged
|
Have you test the file pattern on window? On my windows machine the pattern matching used here always fails when using UNIX path seperator "/" as described in the README. |
Member
|
Might be worth creating a fresh issue for this. |
Member
|
FYI, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a -files switch to allow targeting specific files.
This can be part of a solution to #178, the first part being a script that uses git commands to retrieve a list of staged files.