Use guaranteed binary and source compatibility between releases of Scalafmt#260
Merged
nedtwigg merged 2 commits intodiffplug:masterfrom Jul 24, 2018
Merged
Use guaranteed binary and source compatibility between releases of Scalafmt#260nedtwigg merged 2 commits intodiffplug:masterfrom
nedtwigg merged 2 commits intodiffplug:masterfrom
Conversation
3 tasks
joan38
force-pushed
the
scalafmt-fix
branch
2 times, most recently
from
1704067 to
9da5575
Compare
Member
|
Looks like the change breaks older versions of scalafmt? |
Contributor
Author
|
This drops the support for scalafmt < v0.7.0-RC1. Is it good enough? It's a pretty old version... |
Contributor
Author
|
I tried to run the tests with |
Member
|
Great! All it needs now is updated CHANGES.md:
If your change only affects a build plugin, and not the lib, then you only need to update the CHANGES.md for that plugin. If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and the build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them. |
Member
|
bump |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #252