Skip to content

Applied common Spotless Eclipse framework to CDT#238

Merged
fvgh merged 7 commits intomasterfrom
ext_eclipse_cdt
Aug 6, 2018
Merged

Applied common Spotless Eclipse framework to CDT#238
fvgh merged 7 commits intomasterfrom
ext_eclipse_cdt

Conversation

@fvgh
Copy link
Member

@fvgh fvgh commented Apr 28, 2018

Applied common Spotless Eclipse framework to CDT (see #234).
Updated version and artifact ID as discussed in #226.

@fvgh fvgh changed the title Ext eclipse cdt Applied common Spotless Eclipse framework to CDT Apr 28, 2018
@fvgh fvgh requested a review from nedtwigg April 28, 2018 11:51
fvgh added 2 commits April 29, 2018 13:41
@fvgh
Aligned artifact name in README.
0d5d6d2
@fvgh
Aligned dependency version.
31fec34 
Fixed comments. Added missing package-info.
@nedtwigg nedtwigg mentioned this pull request Jul 20, 2018
Closed
2 tasks
@fvgh fvgh merged commit e1734c0 into master Aug 6, 2018
@nedtwigg
Copy link
Member

nedtwigg commented Aug 7, 2018

I tried to publish but got this error:

Script '/Users/ntwigg/Documents/dev/spotless/_ext/gradle/p2-fat-jar-setup.gradle' line: 75

* What went wrong:
A problem occurred configuring root project 'eclipse-cdt'.
> Could not find method setP2AntProxy() for arguments [### ARGS ###
  --launcher.suppressErrors
  -nosplash
  -application org.eclipse.ant.core.antRunner
  
  ### BUILD.XML ###
  <?xml version="1.0" encoding="UTF-8"?><project>
    <p2.mirror>
      <source>
        <repository location="http://download.eclipse.org/tools/cdt/releases/9.4"/>
        <repository kind="artifact" location="file:///Users/ntwigg/.goomph/shared-bundles"/>
      </source>
      <destination location="file:///Users/ntwigg/Documents/dev/spotless/_ext/eclipse-cdt/build/p2asmaven/p2/p2" append="false"/>
    </p2.mirror>
  </project>
  ] on object of type com.diffplug.gradle.p2.AsMavenGroup.

Similar error in WTP. I didn't try very hard to debug yet. Any low-hanging fruit to check before I debug more? Maybe an uncommitted file?

@fvgh
Copy link
Member Author

fvgh commented Aug 7, 2018 via email

@fvgh fvgh deleted the ext_eclipse_cdt branch August 8, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedtwigg nedtwigg nedtwigg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fvgh @nedtwigg