Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: diffplug/dormouse
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: diffplug/dormouse
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cli-expanded
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 40 files changed
  • 2 contributors

Commits on May 29, 2026

  1. Configuration menu
    Copy the full SHA
    1cd6c3b View commit details
    Browse the repository at this point in the history
  2. Add dor version command

    nedtwigg committed May 29, 2026
    Configuration menu
    Copy the full SHA
    5f84e40 View commit details
    Browse the repository at this point in the history
  3. Add dor send command

    nedtwigg committed May 29, 2026
    Configuration menu
    Copy the full SHA
    95aac98 View commit details
    Browse the repository at this point in the history
  4. Add dor read command

    nedtwigg committed May 29, 2026
    Configuration menu
    Copy the full SHA
    8f84c0b View commit details
    Browse the repository at this point in the history
  5. Add dor kill command

    nedtwigg committed May 29, 2026
    Configuration menu
    Copy the full SHA
    27e21b7 View commit details
    Browse the repository at this point in the history
  6. Add dor iframe surfaces

    nedtwigg committed May 29, 2026
    Configuration menu
    Copy the full SHA
    1821d84 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2026

  1. Merge remote-tracking branch 'origin/add-dor-cli' into cli-expanded

    # Conflicts:
    #	dor/package.json
    nedtwigg committed May 30, 2026
    Configuration menu
    Copy the full SHA
    569fbbe View commit details
    Browse the repository at this point in the history
  2. Make dor kill --confirm-await-user block on the in-app dialog

    The await-user path used window.confirm(), which a Tauri webview doesn't
    support synchronously — it returned false instantly, so the command ended
    immediately as "kill was not confirmed" and the dialog never opened.
    
    Open the existing in-app kill dialog instead and block the control request
    until the user accepts (matching letter) or rejects (Esc/any other key/
    dismiss), wiring acceptKill/rejectKill to resolve the pending promise plus
    a safety net that resolves false if the dialog is dismissed by another path.
    
    A human-paced confirmation also outlasts both deadlines guarding the request,
    so disable them for await-user kills: the dor client passes no timeout, and
    the control server skips its safety-net timer (with a socket-close handler to
    release the now-unbounded pending entry if the client disconnects).
    
    Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
    nedtwigg and claude committed May 30, 2026
    Configuration menu
    Copy the full SHA
    508b804 View commit details
    Browse the repository at this point in the history
  3. Remove dor kill --confirm-await-user

    The await-user mode blocked the CLI call on a human answering an in-app
    modal, but the interaction model doesn't hold up: a CLI invocation hanging
    indefinitely on someone noticing a modal somewhere on screen — with no
    mechanism to route attention to it — is the wrong primitive. The kill-confirm
    dialog was also gated behind the Wall's command mode, so the confirm letter
    never reached it from a terminal in passthrough mode anyway.
    
    The remaining modes cover the real programmatic needs: --confirm-dangerously
    (unconditional) and --confirm-if-read (guard on visible text). A proper
    human-in-the-loop kill would need a non-blocking, attributed notification
    channel; build that if a consumer actually needs it.
    
    Reverts the await-user wiring across the CLI flag/parser, request types,
    control client timeout handling, and the webview handler. Keeps the control
    server's socket-close cleanup, which is a standalone correctness improvement.
    
    Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
    nedtwigg and claude committed May 30, 2026
    Configuration menu
    Copy the full SHA
    d257ced View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'origin/cli-expanded' into cli-expanded

    # Conflicts:
    #	dor/test/snapshots/help/dor.md
    nedtwigg committed May 30, 2026
    Configuration menu
    Copy the full SHA
    494c8d4 View commit details
    Browse the repository at this point in the history
Loading