Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: diffgram/python-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: diffgram/python-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: improve-directory-and-startup
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 6 files changed
  • 1 contributor

Commits on Jun 17, 2022

  1. Upgrade to use class object instead of json 

    -> Before we were using the json which introduced some potential confusion
now it uses the directory object
-> Move functions inside class
-> Move default setting inside here... the API returning default in that way still not best but working in existing pattern
    @anthony-chaudhary
    anthony-chaudhary committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    68dd9cc View commit details
    Browse the repository at this point in the history

  2. Seperate concerns and improve startup 

    -> move default dir and label setting to optional
and more cleanly define at init instead of inside auth
-> use new directory class
-> use new get_directory_list()
-> get dir now checks if none
-> Added print statements for now since still so much changing but those can be optional log statements in future of course
    @anthony-chaudhary
    anthony-chaudhary committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    e38117c View commit details
    Browse the repository at this point in the history

  3. Align with schema direction 

    only schema is needed not directory id
(changing API side too)
    @anthony-chaudhary
    anthony-chaudhary committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    4ac6e86 View commit details
    Browse the repository at this point in the history

  4. Align with new pattern

    @anthony-chaudhary
    anthony-chaudhary committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    a72a041 View commit details
    Browse the repository at this point in the history

  5. opencv should be optional 

    only needed in some cases, heavy requirement to put here
    @anthony-chaudhary
    anthony-chaudhary committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    2b4dbdd View commit details
    Browse the repository at this point in the history

  6. Fix init bug - this was preventing to_tensorflow() from working 

    init_file_ids asumes the id was already set
but for now refresh_from_dict pattern means the id is set after init
so refactor `init_files()` and call it after...

We will need to work on this more

Luckily at least now it's refactored to `convert_json_to_sdk_object()` so we have it only in one place
    @anthony-chaudhary
    anthony-chaudhary committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    3f5ccd7 View commit details
    Browse the repository at this point in the history
Loading