Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 18 commits
- 8 files changed
- 3 contributors
Commits on Feb 7, 2023
-
Merge pull request #27 from diffgram/add-admin-config-project-creation
feat: add config for preventing project creation
-
Commits on Apr 7, 2023
Commits on Jun 6, 2023
-
-
-
Remove create database in Upgrade context
no reason to attempt to create a database in the upgrade context and can cause hard to debug errors
-
-
These dependencies should already exist in cd shared restating them here is confusing, as it confuses what is being called and where the code is running (e.g. assuming it isolated, when it's actually using the shared dependencies already)
Commits on Jul 10, 2023
-
-
-> When using with a subdomain, it appears De Facto that it is not needed to have this listed here -> Rabbit has it's own Cert generated, currently using secret volume diffgram-rabbitmq-certs. -> This can break TLS generating certificate. We shouldn't expect users to have to generate A records for rabbit too, so it would better to leave this empty if that's reasonable. cert-manager/controller/challenges "msg"="propagation check failed" "error"="failed to perform self check GET request 'http://rabbitmq.app.diffgram.com/.
-
-
-> this was in the context of having other ingress files
-
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff add-admin-config-project-creation...main