Graceful Shutdown #359
Merged
Graceful Shutdown #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 12, 2021
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Contributor
Author
|
Hey @Anthony-Sarkis! This PR should now be ready to go. Please let me know if you find any issues with it or if there's something you think we need to change before meging |
anthony-chaudhary
approved these changes
Oct 14, 2021
Member
anthony-chaudhary
left a comment
anthony-chaudhary
left a comment
There was a problem hiding this comment.
Great work!! Looks really good. 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
GracefulKillerclass to catch SIGINT AND SIGTERM signals.main.py, this prevents threads from being recreated on every import of process_media.pyProcessMediaQueueManagerclass to manages all the queues of the worker and centralize the queue management actions.Gracefull Kill Algorithm Overview:
We will check the length of the
FRAME_QUEUE,VIDEO_QUEUEandPROCESSING_INPUT_LISTand wait for a max of 2 hours until they are empty. If they all get empty, we kill the walrus. We also set the flagSTOP_PROCESSING_DATA=Trueto avoid processing new messages on the current worker.If more than 2 hours pass and all the messages are not handled, we set the messages status to
failed.Notes:
This PR should be deployed alongside with this: diffgram/diffgram-helm#5 to allow kubernetes to give a grace period for shutfdown on new deploys
There's still an issue when killing the walrus and a video file is getting written using moviepy. I've created an issue on their repo to ask about ways to gor around this: Zulko/moviepy#1672