-
Notifications
You must be signed in to change notification settings - Fork 0
Package jdk #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Package jdk #1
Conversation
|
Here is the PR @gpinkham. currently the solution is not great so I dont feel comfortable making a PR to the actual repo. I will probably not have time to work on it until next weekend, but once it is at a point I am happy with I will make another PR. Let me know if you have any questions, Ill try my best to help. |
|
@dfirman thanks.. let me try this one. I tried it with the package_jdk branch but it still had the same error.. but I want to try it again. .perhaps I didn't actually use the right module.. but seriously thanks for following up. I'll get back to this after I try it again.. |
|
I added a note in the readme that is critical in order for it to work. You are going to have to make sure to package a jre with your app. I used OpenJDK11 |
|
@dfirman ok thanks Dustin.. I think that will probably kill the project for me. . The thing I am working on is a replacement for a Java Desktop app.. So the users already have Java installed.. our users tend to be in poorer networking conditions so app size is important and it's already way too big (including jars and just Electron in General).. to add a JRE to it will just be too much. . and the Java stuff is edge cases that would be enabled for those who have Java.. I guess I have been hoping for a silver bullet for node-java working.. Perhaps that was too much.. ok thanks. I'll give this some thought and I really do appreciate the help so far! |
Starter code to get an app to work, needs to be improved to make it more stable.