Open
Conversation
The function isTty() in Streams.php returns wrong information. If the output is to an TTY then it returns false and if the output is a pipe or file it returns true, it should be the other way around.
Co-authored-by: Guillaume Seznec <gseznec@ina.fr>
…lable-params PHP 8.4 | Fix implicitly nullable parameters
The `E_STRICT` constant is deprecated as of PHP 8.4 and will be removed in PHP 9.0 (commit went in today). The error level hasn't been in use since PHP 8.0 anyway and was only barely still used in PHP 7.x, so removing the exclusion from the `error_reporting()` setting in the example code shouldn't really make any difference in practice. Ref: * https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant
Before this code tried to replace newlines with empty spaces, but it didn't always work because the new value would only use the replaced string if additional wrapping needed to be done due to size constraints. This updates the code to properly handle new lines in all content by creating an extra row for each one, using the same logic that already existed for wrapping longer content. See wp-cli/entity-command#262 for an example of the currently broken behavior that this PR fixes
* Replace tabs in tables with 4 spaces * Move to `padColumn` * Cast to string
Previously the final table output was trimmed with the intention of removing the last newline. This had an unintended side effect of removing the tab characters from empty columns in the specific case where the last row had one or more empty columns at the end of the row. This makes sure we are only removing the newline character as intended. Add a new unit test to verify this behavior as well.
To avoid deprecation warnings in newer PHP: ``` PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /Users/isla/source/wp-cli-dev/php-cli-tools/lib/cli/table/Tabular.php on line 30 ```
…juncts (#189) Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )