Reduced method complexity

JosXa · JosXa · commit cd4aded091a1 · 2017-10-07T00:47:25.000+02:00
diff --git a/telegram/ext/handler.py b/telegram/ext/handler.py
@@ -117,6 +117,14 @@ def handle_update(self, update, dispatcher):
         """
         raise NotImplementedError
 
+    def __warn_autowire(self):
+        """ Warn if the user has set any `pass_*` flags to True in addition to `autowire` """
+        for flag in self.__get_available_pass_flags():
+            to_pass = bool(getattr(self, flag))
+            if to_pass is True:
+                warnings.warn('If `autowire` is set to `True`, it is unnecessary '
+                              'to provide the `{}` flag.'.format(flag))
+
     def __get_available_pass_flags(self):
         """
         Used to provide warnings if the user decides to use `autowire` in conjunction with
@@ -143,6 +151,7 @@ def set_autowired_flags(self, passable={'update_queue', 'job_queue', 'user_data'
 
         if not self.autowire:
             raise ValueError("This handler is not autowired.")
+        self.__warn_autowire()
 
         if self._autowire_initialized:
             # In case that users decide to change their callback signatures at runtime, give the
@@ -167,13 +176,6 @@ def should_pass_obj(name):
                 return False
             return is_requested
 
-        # Check whether the user has set any `pass_*` flag to True in addition to `autowire`
-        for flag in self.__get_available_pass_flags():
-            to_pass = bool(getattr(self, flag))
-            if to_pass is True:
-                warnings.warn('If `autowire` is set to `True`, it is unnecessary '
-                              'to provide the `{}` flag.'.format(flag))
-
         if should_pass_obj('update_queue'):
             self.pass_update_queue = True
         if should_pass_obj('job_queue'):
