Added Test case for private extractor method

JosXa · JosXa · commit be20c2636ac5 · 2017-10-02T15:07:37.000+02:00
diff --git a/telegram/utils/helpers.py b/telegram/utils/helpers.py
@@ -105,8 +105,11 @@ def mention_markdown(user_id, name):
         return '[{}](tg://user?id={})'.format(escape_markdown(name), user_id)
 
 
-def __extract_urls(text):
-    """Returns a list of urls from a text string."""
+def _extract_urls_from_text(text):
+    """
+    Returns a list of urls from a text string.
+    URLs without a leading `http://` or `www.` won't be found.
+    """
     out = []
     for word in text.split(' '):
         thing = urlparse(word.strip())
@@ -138,7 +141,7 @@ def extract_urls(message):
                 else k.url for k, v in results.items()]
 
     if message.caption:
-        all_urls += __extract_urls(message.caption)
+        all_urls += _extract_urls_from_text(message.caption)
 
     # Remove exact duplicates
     urls = OrderedDict({k: None for k in all_urls})
diff --git a/tests/test_helpers.py b/tests/test_helpers.py
@@ -29,6 +29,13 @@ def test_escape_markdown(self):
 
         assert expected_str == helpers.escape_markdown(test_str)
 
+    def test_extract_urls_from_text(self):
+        urls = "http://google.com and http://github.com/ and python-telegram-bot.readthedocs.io/en/latest/"
+        result = helpers._extract_urls_from_text(urls)
+        assert len(result) == 2
+        assert result[0] == 'http://google.com'
+        assert result[1] == 'http://github.com/'
+
     def test_extract_urls_entities(self):
         test_entities = [{
             'length': 6, 'offset': 0, 'type': 'text_link',
