Also sorting urls

JosXa · JosXa · commit a2cb0b488092 · 2017-10-07T02:52:59.000+02:00
diff --git a/telegram/utils/helpers.py b/telegram/utils/helpers.py
@@ -42,6 +42,7 @@ def _timestamp(dt_obj):
     # Python < 3.3 (incl 2.7)
     from time import mktime
 
+
     def _timestamp(dt_obj):
         return mktime(dt_obj.timetuple())
 
@@ -146,6 +147,8 @@ def extract_urls(message):
     # Strip trailing slash from URL so we can compare them for equality
     stripped_urls = [x[:-1] if x[-1] == '/' else x for x in all_urls]
 
+    sorted_urls = sorted(stripped_urls, key=str.lower)
+
     # Remove exact duplicates
-    urls = OrderedDict({k: None for k in stripped_urls})
+    urls = OrderedDict({k: None for k in sorted_urls})
     return list(urls.keys())
diff --git a/tests/test_helpers.py b/tests/test_helpers.py
@@ -58,7 +58,6 @@ def test_extract_urls_entities(self):
 
         assert len(result) == 2
         assert (test_entities[0]['url'][:-1] == result[0])
-        assert (result[0] == 'http://github.com')
         assert (test_entities[2]['url'] == result[1])
 
     def test_extract_urls_caption(self):
