ConversationHandler breaks when bot is also used in Channels (python-telegram-bot#487)

JosXa · tsnoam · commit 6a011648971c · 2016-12-25T22:36:01.000+02:00
* ConversationHandler now ignores channel posts
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -32,6 +32,7 @@ The following wonderful people contributed directly or indirectly to this projec
 - `overquota <https://github.com/overquota>`_
 - `Patrick Hofmann <https://github.com/PH89>`_
 - `Rahiel Kasim <https://github.com/rahiel>`_
+- `Joscha Götzer <https://github.com/Rostgnom>`_
 - `Shelomentsev D <https://github.com/shelomentsevd>`_
 - `sooyhwang <https://github.com/sooyhwang>`_
 - `Valentijn <https://github.com/Faalentijn>`_
diff --git a/telegram/ext/conversationhandler.py b/telegram/ext/conversationhandler.py
@@ -28,7 +28,9 @@
 
 class ConversationHandler(Handler):
     """
-    A handler to hold a conversation with a user by managing four collections of other handlers.
+    A handler to hold a conversation with a single user by managing four collections of other
+    handlers. Note that neither posts in Telegram Channels, nor group interactions with multiple
+    users are managed by instances of this class.
 
     The first collection, a ``list`` named ``entry_points``, is used to initiate the conversation,
     for example with a ``CommandHandler`` or ``RegexHandler``.
@@ -113,7 +115,8 @@ def __init__(self,
 
     def check_update(self, update):
 
-        if not isinstance(update, Update):
+        # Ignore messages in channels
+        if not isinstance(update, Update) or update.channel_post:
             return False
 
         chat, user = extract_chat_and_user(update)
