increasing coverage

Eldinnie · Eldinnie · commit 65b8d65dcbfe · 2018-02-22T13:27:54.000+01:00
diff --git a/tests/test_dispatcher.py b/tests/test_dispatcher.py
@@ -16,6 +16,7 @@
 #
 # You should have received a copy of the GNU Lesser Public License
 # along with this program.  If not, see [http://www.gnu.org/licenses/].
+import logging
 from queue import Queue
 from threading import current_thread
 from time import sleep
@@ -82,6 +83,18 @@ def test_error_handler(self, dp):
         sleep(.1)
         assert self.received is None
 
+    def test_construction_with_bad_persistence(self, caplog, bot):
+        class my_per:
+            def __init__(self):
+                self.store_user_data = False
+                self.store_chat_data = False
+
+        with caplog.at_level(logging.WARNING):
+            Dispatcher(bot, None, persistence=my_per())
+        rec = caplog.records[-1]
+        assert rec.msg == 'persistence should be based on Telegram.ext.BasePersistence'
+        assert rec.levelname == 'WARNING'
+
     def test_error_handler_that_raises_errors(self, dp):
         """
         Make sure that errors raised in error handlers don't break the main loop of the dispatcher
diff --git a/tests/test_pickle_persistence.py b/tests/test_pickle_persistence.py
@@ -81,8 +81,11 @@ def update(bot):
 class TestPickelPersistence(object):
     def test_no_files_present_multi_file(self, pickle_persistence):
         assert pickle_persistence.get_user_data() == defaultdict(dict)
+        assert pickle_persistence.get_user_data() == defaultdict(dict)
+        assert pickle_persistence.get_chat_data() == defaultdict(dict)
         assert pickle_persistence.get_chat_data() == defaultdict(dict)
         assert pickle_persistence.get_conversations('noname') == {}
+        assert pickle_persistence.get_conversations('noname') == {}
 
     def test_no_files_present_single_file(self, pickle_persistence):
         pickle_persistence.single_file = True
@@ -219,6 +222,8 @@ def test_updating_single_file(self, pickle_persistence, good_pickle_files):
         assert conversations_test['name1'] == conversation1
 
     def test_save_on_flush_multi_files(self, pickle_persistence, good_pickle_files):
+        # Should run without error
+        pickle_persistence.flush()
         pickle_persistence.on_flush = True
 
         user_data = pickle_persistence.get_user_data()
@@ -268,6 +273,9 @@ def test_save_on_flush_multi_files(self, pickle_persistence, good_pickle_files):
         assert conversations_test['name1'] == conversation1
 
     def test_save_on_flush_single_files(self, pickle_persistence, good_pickle_files):
+        # Should run without error
+        pickle_persistence.flush()
+
         pickle_persistence.on_flush = True
         pickle_persistence.single_file = True
 
